git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH 0/3] gitweb: Refactor common parts of log-like views

From
Jakub Narebski <jnareb@gmail.com>
Date
Nov 13, 2009, 01:02 UTC
Message-ID
<1258074134-27011-1-git-send-email-jnareb@gmail.com>

This series extracts common parts of log-like views: 'log', 'shortlog' and 'history' view, into git_log_generic() subroutine. This unification of code reduces code duplication, and brings features such as limiting the list of commits displayed using $hash_parent{,_base} from 'shortlog' view (added in ec3e97b (gitweb: shortlog now also obeys $hash_parent, 2008-08-08)).

I have tested this series a bit (it passes both t9500 and t9501 test), but I didn't test all the corner cases.

This series is preparation for even more refactoring planned, to make it easier to introduce new log-like action (new log formats). It doesn't include (for now) the 'search' view, neither in message search not in pickaxe search form.

Jakub Narebski (3):
  gitweb: Refactor 'log' action generation, adding git_log_body()
  gitweb: Refactor common parts of 'log' and 'shortlog' views
  gitweb: Make 'history' view (re)use git_log_generic()
 gitweb/gitweb.perl |  269 +++++++++++++++++++++-------------------------------
 1 files changed, 110 insertions(+), 159 deletions(-)
-- 
Jakub Narebski
Next: Jakub Narebski
Message 1 of 6 in “gitweb: Refactor common parts of log-like views”
  1. 0/3 gitweb: Refactor common parts of log-like viewsJakub Narebski, Nov 13, 2009
  2. 1/3 gitweb: Refactor 'log' action generation, adding git_log_body()Jakub Narebski, Nov 13, 2009
  3. Nanako ShiraishiNov 13, 2009
  4. Jakub NarebskiNov 13, 2009
  5. 2/3 gitweb: Refactor common parts of 'log' and 'shortlog' viewsJakub Narebski, Nov 13, 2009
  6. 3/3 gitweb: Make 'history' view (re)use git_log_generic()Jakub Narebski, Nov 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.