From: Jakub Narebski <jnareb@gmail.com>
Date: Fri, 13 Nov 2009 23:59:07 GMT
Subject: Re: [PATCH 1/3] gitweb: Refactor 'log' action generation, adding git_log_body()
Message-ID: <200911140059.08084.jnareb@gmail.com>
In-Reply-To: <20091114081050.6117@nanako3.lavabit.com>

On Sat, 14 Nov 2009, Nanako Shiraishi wrote:
> Quoting Jakub Narebski <jnareb@gmail.com>
> 
> > Put the main part of 'log' view generation into git_log_body,
> > similarly how it is done for 'shortlog' and 'history' views (and
> > also for 'tags' and 'heads' views).
> >
> > This is preparation for extracting common code between 'log',
> > 'shortlog' and 'history' actions.
> >
> > Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> > ---
> > This is pure refactoring: output should change.
> 
> Did you mean "should not change"?

Yes, of course, it should be "output should not change" (as opposed
to later patches, which unify not only code but some of looks).

-- 
Jakub Narebski
Poland