git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Set Makefile variables from configure

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 4, 2009, 20:16 UTC
Message-ID
<20091104201657.GA30073@progeny.tock>
In-Reply-To
<1257363937-sup-5123@ntdws12.chass.utoronto.ca>
Ben Walton wrote:
Show 12 quoted lines
> Excerpts from Junio C Hamano's message of Wed Nov 04 14:36:32 -0500 2009:
> 
>> I am a bit puzzled about the "warning" logic.  Is this because you expect
>> variables we typically give YesPlease/NoThanks as their values will not be
>> handled with this new PARSE_WITH_SET_MAKE_VAR() macro?
> 
> No, this is because it's perfectly acceptable, in my opinion for a
> user to say:
> 
> --with-pager=no
> or
> --with-editor=yes

More to the point, that’s what autoconf gives for "--without-pager" or plain "--with-editor". It seems strange to silently use PAGER=no or EDITOR=yes in that case.

Maybe the options should just be --pager=foo and --editor=bar, which would be less misleading and avoid this problem. But this is not my itch (I find it cleaner to use the Makefile directly), so I have no strong opinion. Unfortunately, my autoconf-fu is too weak for a demo.

Jonathan
Previous: Ben WaltonNext: Ben Walton
Message 14 of 15 in “Set Makefile variables from configure”
  1. 0/2 Set Makefile variables from configureBen Walton, Oct 31, 2009
  2. 1/2 configure: add function to directly set Makefile variablesBen Walton, Oct 31, 2009
  3. 2/2 configure: allow user to set gitconfig, pager and editorBen Walton, Oct 31, 2009
  4. Ben WaltonNov 3, 2009
  5. Jonathan NiederNov 3, 2009
  6. Jonathan NiederNov 3, 2009
  7. 0/2 Set Makefile variables from configureBen Walton, Nov 4, 2009
  8. 1/2 configure: add macro to set arbitrary make variablesBen Walton, Nov 4, 2009
  9. 2/2 configure: add settings for gitconfig, editor and pagerBen Walton, Nov 4, 2009
  10. Junio C HamanoNov 4, 2009
  11. Ben WaltonNov 4, 2009
  12. Junio C HamanoNov 4, 2009
  13. Ben WaltonNov 4, 2009
  14. Jonathan NiederNov 4, 2009
  15. Ben WaltonNov 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.