From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 04 Nov 2009 20:16:58 GMT
Subject: Re: [PATCH 0/2] Set Makefile variables from configure
Message-ID: <20091104201657.GA30073@progeny.tock>
In-Reply-To: <1257363937-sup-5123@ntdws12.chass.utoronto.ca>

Ben Walton wrote:
> Excerpts from Junio C Hamano's message of Wed Nov 04 14:36:32 -0500 2009:
> 
>> I am a bit puzzled about the "warning" logic.  Is this because you expect
>> variables we typically give YesPlease/NoThanks as their values will not be
>> handled with this new PARSE_WITH_SET_MAKE_VAR() macro?
> 
> No, this is because it's perfectly acceptable, in my opinion for a
> user to say:
> 
> --with-pager=no
> or
> --with-editor=yes

More to the point, that’s what autoconf gives for "--without-pager" or
plain "--with-editor".  It seems strange to silently use PAGER=no or
EDITOR=yes in that case.

Maybe the options should just be --pager=foo and --editor=bar, which
would be less misleading and avoid this problem.  But this is not my
itch (I find it cleaner to use the Makefile directly), so I have no
strong opinion.  Unfortunately, my autoconf-fu is too weak for a demo.

Jonathan