[PATCH 0/2] Set Makefile variables from configure
- From
Ben Walton <bwalton@artsci.utoronto.ca>
- Date
- Nov 4, 2009, 18:05 UTC
- Message-ID
- <1257357960-12763-1-git-send-email-bwalton@artsci.utoronto.ca>
- In-Reply-To
- <20091103222123.GA17097@progeny.tock>
Ok, a second attempt, taking into account Jonathan's feedback and proposed updates. The revised macro allows for specified help text.
I opted to use a more 'dry' approach to the macro instead of repeating the boilerplate AC_WITH_ARG bits when calling this feature.
Additionally, I only WARN when 'yes' or 'no' is passed. Bailing on errors in most cases is reasonable, but I don't think it's globally appropriate.
As to why I want this...It's cleaner, in my opinion, to do all build configuration through a single mechanism than to do most with ./configure and the rest with variables passed to make. In other words, this is purely a style issue.
I like the extension of config.mak.in to support more of the autoconf variables as well and would like to see it applied.
Ben Walton (2): configure: add macro to set arbitrary make variables configure: add settings for gitconfig, editor and pager
configure.ac | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 43 insertions(+), 0 deletions(-)