git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Set Makefile variables from configure

From
Ben Walton <bwalton@artsci.utoronto.ca>
Date
Nov 4, 2009, 18:05 UTC
Message-ID
<1257357960-12763-1-git-send-email-bwalton@artsci.utoronto.ca>
In-Reply-To
<20091103222123.GA17097@progeny.tock>

Ok, a second attempt, taking into account Jonathan's feedback and proposed updates. The revised macro allows for specified help text.

I opted to use a more 'dry' approach to the macro instead of repeating the boilerplate AC_WITH_ARG bits when calling this feature.

Additionally, I only WARN when 'yes' or 'no' is passed. Bailing on errors in most cases is reasonable, but I don't think it's globally appropriate.

As to why I want this...It's cleaner, in my opinion, to do all build configuration through a single mechanism than to do most with ./configure and the rest with variables passed to make. In other words, this is purely a style issue.

I like the extension of config.mak.in to support more of the autoconf variables as well and would like to see it applied.

Ben Walton (2):
  configure: add macro to set arbitrary make variables
  configure: add settings for gitconfig, editor and pager
 configure.ac |   43 +++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 43 insertions(+), 0 deletions(-)
Previous: Jonathan NiederNext: Ben Walton
Message 7 of 15 in “Set Makefile variables from configure”
  1. 0/2 Set Makefile variables from configureBen Walton, Oct 31, 2009
  2. 1/2 configure: add function to directly set Makefile variablesBen Walton, Oct 31, 2009
  3. 2/2 configure: allow user to set gitconfig, pager and editorBen Walton, Oct 31, 2009
  4. Ben WaltonNov 3, 2009
  5. Jonathan NiederNov 3, 2009
  6. Jonathan NiederNov 3, 2009
  7. 0/2 Set Makefile variables from configureBen Walton, Nov 4, 2009
  8. 1/2 configure: add macro to set arbitrary make variablesBen Walton, Nov 4, 2009
  9. 2/2 configure: add settings for gitconfig, editor and pagerBen Walton, Nov 4, 2009
  10. Junio C HamanoNov 4, 2009
  11. Ben WaltonNov 4, 2009
  12. Junio C HamanoNov 4, 2009
  13. Ben WaltonNov 4, 2009
  14. Jonathan NiederNov 4, 2009
  15. Ben WaltonNov 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.