git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: More generous accepting of RFC-2822 footer lines.

From
David Brown <davidb@quicinc.com>
Date
Oct 28, 2009, 14:23 UTC
Message-ID
<20091028142328.GA13343@huya.quicinc.com>
In-Reply-To
<7vk4yguh00.fsf@alter.siamese.dyndns.org>
On Wed, Oct 28, 2009 at 12:14:55AM -0700, Junio C Hamano wrote:
> When deciding to omit adding a new S-o-b, we deliberately check only the
> last S-o-b to see if it matches what we are trying to add.  This is so
> that a message from you, that has my patch that was reviewed and touched
> up by you with your sign-off, i.e.

This is good to know. I'll leave the existing last-SoB test in place then, and just use the sophisticated check for a block of RFC2822 footers to determine if there should be a blank line.

Jeff also pointed out that I should probably also allow lines starting with whitespace to be considered header lines.

David
Previous: Junio C HamanoNext: David Brown
Message 4 of 11 in “commit: More generous accepting of RFC-2822 footer lines.”
  1. commit: More generous accepting of RFC-2822 footer lines.David Brown, Oct 27, 2009
  2. Shawn O. PearceOct 28, 2009
  3. Junio C HamanoOct 28, 2009
  4. David BrownOct 28, 2009
  5. commit: More generous accepting of RFC-2822 footer lines.David Brown, Oct 28, 2009
  6. Junio C HamanoOct 28, 2009
  7. David BrownOct 28, 2009
  8. SZEDER GáborNov 3, 2009
  9. commit: fix too generous RFC-2822 footer handlingSZEDER Gábor, Nov 4, 2009
  10. Junio C HamanoNov 4, 2009
  11. SZEDER GáborNov 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.