From: David Brown Date: Wed, 28 Oct 2009 14:23:28 GMT Subject: Re: [PATCH] commit: More generous accepting of RFC-2822 footer lines. Message-ID: <20091028142328.GA13343@huya.quicinc.com> In-Reply-To: <7vk4yguh00.fsf@alter.siamese.dyndns.org> On Wed, Oct 28, 2009 at 12:14:55AM -0700, Junio C Hamano wrote: > When deciding to omit adding a new S-o-b, we deliberately check only the > last S-o-b to see if it matches what we are trying to add. This is so > that a message from you, that has my patch that was reviewed and touched > up by you with your sign-off, i.e. This is good to know. I'll leave the existing last-SoB test in place then, and just use the sophisticated check for a block of RFC2822 footers to determine if there should be a blank line. Jeff also pointed out that I should probably also allow lines starting with whitespace to be considered header lines. David