[PATCH] commit: More generous accepting of RFC-2822 footer lines.
- From
David Brown <davidb@codeaurora.org>
- Date
- Oct 27, 2009, 23:45 UTC
- Message-ID
- <20091027234520.GA11433@quaoar.codeaurora.org>
From: David Brown <davidb@quicinc.com>
'git commit -s' will insert a blank line before the Signed-off-by line at the end of the message, unless this last line is a Signed-off-by line itself. Common use has other trailing lines at the ends of commit text, in the style of RFC2822 headers.
Be more generous in considering lines to be part of this footer. This may occasionally leave out the blank line for cases where the commit text happens to start with a word ending in a colon, but this results in less fixups than the extra blank lines with Acked-by, or other custom footers.
Signed-off-by: David Brown <davidb@quicinc.com> --- builtin-commit.c | 17 ++++++++++++++++- t/t7501-commit.sh | 19 +++++++++++++++++++ 2 files changed, 35 insertions(+), 1 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c index 200ffda..f081e80 100644 --- a/builtin-commit.c +++ b/builtin-commit.c @@ -414,6 +414,21 @@ static void determine_author_info(void) author_date = date; } +static int is_rfc2822_footer(const char *line) +{ + int ch; + + while ((ch = *line++)) { + if (ch == ':') + return 1; + if ((33 <= ch && ch <= 57) || + (59 <= ch && ch <= 126)) + continue; + break; + } + return 0; +} + static int prepare_to_commit(const char *index_file, const char *prefix, struct wt_status *s) { @@ -489,7 +504,7 @@ static int prepare_to_commit(const char *index_file, const char *prefix, for (i = sb.len - 1; i > 0 && sb.buf[i - 1] != '\n'; i--) ; /* do nothing */ if (prefixcmp(sb.buf + i, sob.buf)) { - if (prefixcmp(sb.buf + i, sign_off_header)) + if (!is_rfc2822_footer(sb.buf + i)) strbuf_addch(&sb, '\n'); strbuf_addbuf(&sb, &sob); } diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh index e2ef532..05542b4 100755 --- a/t/t7501-commit.sh +++ b/t/t7501-commit.sh @@ -247,6 +247,25 @@ $existing" && ' +test_expect_success 'signoff gap' ' + + echo 3 >positive && + git add positive && + alt="Alt-RFC-822-Header: Value" && + git commit -s -m "welcome + +$alt" && + git cat-file commit HEAD | sed -e "1,/^\$/d" > actual && + ( + echo welcome + echo + echo $alt + git var GIT_COMMITTER_IDENT | + sed -e "s/>.*/>/" -e "s/^/Signed-off-by: /" + ) >expected && + test_cmp expected actual +' + test_expect_success 'multiple -m' ' >negative &&
-- 1.6.5.1