git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: set PERL_PATH and SHELL_PATH unconditionally

From
MKMatt Kraai <kraai@ftbfs.org>
Date
Oct 20, 2009, 16:33 UTC
Message-ID
<20091020163307.GA5208@ftbfs.org>
In-Reply-To
<7vtyxuox7u.fsf@alter.siamese.dyndns.org>
On Tue, Oct 20, 2009 at 09:18:29AM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> Matt Kraai <kraai@ftbfs.org> writes:
> 
> > Do not check whether PERL_PATH and SHELL_PATH are undefined before
> > setting their default values.  This prevents them from being set via
> > environment variables.
> 
> Is there an upside of "preventing them from getting set", by the way?
Not that I know of.

I originally thought that the checks were superfluous, but now I just believe they're inconsistent and confusing to people like me who think they understand Makefiles but don't. :)

-- 
Matt Kraai                                             http://ftbfs.org/
Previous: Junio C Hamano
Message 5 of 5 in “Extra checks for PERL_PATH and SHELL_PATH?”
  1. Matt KraaiOct 20, 2009
  2. Junio C HamanoOct 20, 2009
  3. Makefile: set PERL_PATH and SHELL_PATH unconditionallyMatt Kraai, Oct 20, 2009
  4. Junio C HamanoOct 20, 2009
  5. Matt KraaiOct 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.