git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Extra checks for PERL_PATH and SHELL_PATH?

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 20, 2009, 06:36 UTC
Message-ID
<7vr5syshat.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20091020035051.GA3237@ftbfs.org>
Matt Kraai <kraai@ftbfs.org> writes:
Show 12 quoted lines
> The top-level Makefile currently contains
>
>> ifndef SHELL_PATH
>> 	SHELL_PATH = /bin/sh
>> endif
>> ifndef PERL_PATH
>> 	PERL_PATH = /usr/bin/perl
>> endif
>
> The checks are only necessary if these variables need to be overridden
> by environment variables, not just via the make command line.  Is this
> the case?

It may not have been the original intention, but the above would mean that some people may have learned to run "SHELL_PATH=/bin/ksh make" and changing it would break things for them, no?

I do not think changing them is bad per-se, but we would need to add extra warnings in the release note to explain this change, that's all. This would only affect people who build from the source (including distro people) so it is not really a big deal.

Previous: Matt KraaiNext: Matt Kraai
Message 2 of 5 in “Extra checks for PERL_PATH and SHELL_PATH?”
  1. Matt KraaiOct 20, 2009
  2. Junio C HamanoOct 20, 2009
  3. Makefile: set PERL_PATH and SHELL_PATH unconditionallyMatt Kraai, Oct 20, 2009
  4. Junio C HamanoOct 20, 2009
  5. Matt KraaiOct 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.