From: Matt Kraai <kraai@ftbfs.org>
Date: Tue, 20 Oct 2009 16:33:07 GMT
Subject: Re: [PATCH] Makefile: set PERL_PATH and SHELL_PATH unconditionally
Message-ID: <20091020163307.GA5208@ftbfs.org>
In-Reply-To: <7vtyxuox7u.fsf@alter.siamese.dyndns.org>

On Tue, Oct 20, 2009 at 09:18:29AM -0700, Junio C Hamano wrote:
> Matt Kraai <kraai@ftbfs.org> writes:
> 
> > Do not check whether PERL_PATH and SHELL_PATH are undefined before
> > setting their default values.  This prevents them from being set via
> > environment variables.
> 
> Is there an upside of "preventing them from getting set", by the way?

Not that I know of.

I originally thought that the checks were superfluous, but now I just
believe they're inconsistent and confusing to people like me who think
they understand Makefiles but don't.  :)

-- 
Matt Kraai                                             http://ftbfs.org/