git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [StGit PATCH] Add import -p option

From
Karl Wiberg <kha@treskal.com>
Date
Sep 8, 2009, 22:37 UTC
Message-ID
<20090908223714.GA6364@diana.vm.bytemark.co.uk>
In-Reply-To
<b0943d9e0909081443g47978cb7mee241d74dc52adf7@mail.gmail.com>
On 2009-09-08 22:43:39 +0100, Catalin Marinas wrote:
> This patch renames some of the existing import options and adds the
> -p (--strip) option which allows stripping the leading slashes of
> the diff paths.

Looks good (and the intent is very good). The import test should probably be augmented with a test case for -pN, though. (And since you didn't have to change the test in this patch, presumably the two options you renamed weren't tested either.)

> +    if strip:
> +        cmd += ['-p', strip]

This test should probably be "if strip != None". It doesn't _really_ matter, technically, since -p0 is the default, but still ...

-- 
Karl Wiberg, kha@treskal.com
    www.treskal.com/kalle
Previous: Catalin MarinasNext: Catalin Marinas
Message 2 of 4 in “Add import -p option”
  1. Add import -p optionCatalin Marinas, Sep 8, 2009
  2. Karl WibergSep 8, 2009
  3. Catalin MarinasSep 9, 2009
  4. Karl WibergSep 10, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.