From: Karl Wiberg Date: Tue, 08 Sep 2009 22:37:14 GMT Subject: Re: [StGit PATCH] Add import -p option Message-ID: <20090908223714.GA6364@diana.vm.bytemark.co.uk> In-Reply-To: On 2009-09-08 22:43:39 +0100, Catalin Marinas wrote: > This patch renames some of the existing import options and adds the > -p (--strip) option which allows stripping the leading slashes of > the diff paths. Looks good (and the intent is very good). The import test should probably be augmented with a test case for -pN, though. (And since you didn't have to change the test in this patch, presumably the two options you renamed weren't tested either.) > + if strip: > + cmd += ['-p', strip] This test should probably be "if strip != None". It doesn't _really_ matter, technically, since -p0 is the default, but still ... -- Karl Wiberg, kha@treskal.com www.treskal.com/kalle