Re: [StGit PATCH] Add import -p option

From: Karl Wiberg <kha@treskal.com>
Date: Sep 10, 2009, 08:24 UTC
Message-ID: <20090910082436.GA1388@diana.vm.bytemark.co.uk>
In-Reply-To: <b0943d9e0909091509i16b556f0x9dd3aa6788054298@mail.gmail.com>

On 2009-09-09 23:09:51 +0100, Catalin Marinas wrote:

Show 13 quoted lines

> 2009/9/8 Karl Wiberg <kha@treskal.com>:
>
> > On 2009-09-08 22:43:39 +0100, Catalin Marinas wrote:
> >
> > > +    if strip:
> > > +        cmd += ['-p', strip]
> >
> > This test should probably be "if strip != None". It doesn't
> > _really_ matter, technically, since -p0 is the default, but still
> > ...
>
> I modified it after posting the patch. The git default is -p1, so we
> would miss the -p0 case.

Ah ha! Sometimes it actually does pay to be pedantic ...

-- 
Karl Wiberg, kha@treskal.com
    www.treskal.com/kalle