git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git_remote_cvs: Honor DESTDIR in the Makefile

From
Johan Herland <johan@herland.net>
Date
Aug 17, 2009, 01:58 UTC
Message-ID
<200908170358.30347.johan@herland.net>
In-Reply-To
<20090816210300.GB23522@gmail.com>
On Sunday 16 August 2009, David Aguilar wrote:
> I'll see if we rework this so that we end up passing "" to
> --root instead of /.  I'm going to be gone for a few hours so
> probably won't be able to try it out until tonight.

Thanks a lot for your work! I will send an updated series shortly which will include v2 of your DESTDIR/Makefile fixes, and also the fixes you suggested earlier (including _lots_ of PEP8 fixes).

Show 10 quoted lines
> Another thing to consider --
>
> Debian once submitted a bug against another Python app asking
> that we not place modules in site-packages unless we
> plan on having other applications importing those modules.
>
> The more appropriate place for them if we don't plan on that is
> $(prefix)/share/git-core/git_remote_cvs or something like that.
>
> I guess that's another thing to think about.

Yes, Debian raises a valid point. I haven't thought much about making the git_remote_cvs package into something that would be useful for other applications. (I just assumed that the Python convention was to install it into site-packages regardless...) For now, I'll concentrate on git-remote- cvs, and leave it to others to figure out if anything in the git_remote_cvs package is useful for other programs.

Note that there's a small chicken-and-egg problem here as well: If Debian refuses us to install into site-packages, it will be harder for other Python programs to discover (and import) the git_remote_cvs package.

BTW, when we're on the subject of packaging: There are some variables in git_remote_cvs/setup.py where I'm not sure what the correct value should be:

- version - should this follow Git's version number, or is it independent?
- author (and author_email + url) - For now, I'm referring to the Git 
community. Should this be more specific/
Feedback welcome.
Have fun! :)
...Johan
-- 
Johan Herland, <johan@herland.net>
www.herland.net
Previous: Johannes SchindelinNext: David Aguilar
Message 18 of 22 in “[RFCv3 0/4] CVS remote helper”
  1. Johan HerlandAug 12, 2009
  2. 1/4 Basic build infrastructure for Python scriptsJohan Herland, Aug 12, 2009
  3. 2/4 Add Python support library for CVS remote helperJohan Herland, Aug 12, 2009
  4. David AguilarAug 12, 2009
  5. Johan HerlandAug 12, 2009
  6. Sverre RabbelierAug 12, 2009
  7. Michael HaggertyAug 13, 2009
  8. Johan HerlandAug 13, 2009
  9. Junio C HamanoAug 13, 2009
  10. Johan HerlandAug 13, 2009
  11. Junio C HamanoAug 16, 2009
  12. 1/2 git_remote_cvs: Honor DESTDIR in the MakefileDavid Aguilar, Aug 16, 2009
  13. 2/2 git_remote_cvs: Use $(shell) in the MakefileDavid Aguilar, Aug 16, 2009
  14. David AguilarAug 16, 2009
  15. Johannes SchindelinAug 16, 2009
  16. David AguilarAug 16, 2009
  17. Johannes SchindelinAug 16, 2009
  18. Johan HerlandAug 17, 2009
  19. 1/2 git_remote_cvs: Honor DESTDIR in the MakefileDavid Aguilar, Aug 16, 2009
  20. 2/2 git_remote_cvs: Use $(shell) in the MakefileDavid Aguilar, Aug 16, 2009
  21. 3/4 Third draft of CVS remote helper programJohan Herland, Aug 12, 2009
  22. 4/4 Add simple selftests of git-remote-cvs functionalityJohan Herland, Aug 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.