Re: [PATCH 2/2] git_remote_cvs: Use $(shell) in the Makefile

From: David Aguilar <davvid@gmail.com>
Date: Aug 16, 2009, 20:47 UTC
Message-ID: <20090816204658.GA23522@gmail.com>
In-Reply-To: <1250455088-23457-2-git-send-email-davvid@gmail.com>

On Sun, Aug 16, 2009 at 01:38:08PM -0700, David Aguilar wrote:

Show 5 quoted lines

> This updates the git_remote_cvs Makefile to use the same
> $(shell <cmd>) style used by the top-level git Makefile.
> 
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---

I should have mentioned here that I also spaced stuff out and chopped the long line so that it fits within 78 chars.

I intentionally broke this out as a 2nd patch in case using $(shell ...) was not the right thing to do.

Show 33 quoted lines

>  git_remote_cvs/Makefile |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/git_remote_cvs/Makefile b/git_remote_cvs/Makefile
> index f52c096..d281d48 100644
> --- a/git_remote_cvs/Makefile
> +++ b/git_remote_cvs/Makefile
> @@ -23,10 +23,13 @@ ifndef V
>  	QUIETSETUP = --quiet
>  endif
>  
> -PYLIBDIR=`$(PYTHON_PATH) -c "import sys; print 'lib/python%i.%i/site-packages' % sys.version_info[:2]"`
> +PYLIBDIR=$(shell $(PYTHON_PATH) -c \
> +	 "import sys; \
> +	 print 'lib/python%i.%i/site-packages' % sys.version_info[:2]")
>  
>  all: $(pysetupfile)
>  	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) build
> +
>  install: $(pysetupfile)
>  	$(PYTHON_PATH) $(pysetupfile) install \
>  		--prefix $(prefix) \
> @@ -34,6 +37,7 @@ install: $(pysetupfile)
>  
>  instlibdir: $(pysetupfile)
>  	@echo "$(prefix)/$(PYLIBDIR)"
> +
>  clean:
>  	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a
>  	$(RM) *.pyo *.pyc
> -- 
> 1.6.4.169.g64d5
>

-- 
		David