git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git_remote_cvs: Honor DESTDIR in the Makefile

From
David Aguilar <davvid@gmail.com>
Date
Aug 16, 2009, 21:03 UTC
Message-ID
<20090816210300.GB23522@gmail.com>
In-Reply-To
<alpine.DEB.1.00.0908162251360.8306@pacific.mpi-cbg.de>
On Sun, Aug 16, 2009 at 10:55:29PM +0200, Johannes Schindelin wrote:
Show 24 quoted lines
> Hi,
> 
> On Sun, 16 Aug 2009, David Aguilar wrote:
> 
> > diff --git a/git_remote_cvs/Makefile b/git_remote_cvs/Makefile
> > index 8dbf3fa..f52c096 100644
> > --- a/git_remote_cvs/Makefile
> > +++ b/git_remote_cvs/Makefile
> > @@ -3,6 +3,15 @@
> >  #
> >  pysetupfile:=setup.py
> >  
> > +# Setup the DESTDIR for Python.
> > +ifeq ($(DESTDIR),)
> > +PYTHON_DESTDIR = /
> 
> Hmm.  I think this would break on msysGit.  Not that anybody worked on 
> getting Python to compile on msysGit.
> 
> (Just to make sure you understand the issue: on msysGit, we set prefix to 
> "" (and I think DESTDIR somehow ends up taking on the same value).  Now, 
> when DESTDIR is set to "/" and something wants to be copied to 
> $(DESTDIR)/something, the latter expands to //something, which tells MSys 
> not to expand //something to the correct Windows path.
I see.  Hmm.. setup.py is a real pain.

I'll see if we rework this so that we end up passing "" to --root instead of /. I'm going to be gone for a few hours so probably won't be able to try it out until tonight.

Another thing to consider --

Debian once submitted a bug against another Python app asking that we not place modules in site-packages unless we plan on having other applications importing those modules.

The more appropriate place for them if we don't plan on that is $(prefix)/share/git-core/git_remote_cvs or something like that.

I guess that's another thing to think about.
-- 
		David
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 16 of 22 in “[RFCv3 0/4] CVS remote helper”
  1. Johan HerlandAug 12, 2009
  2. 1/4 Basic build infrastructure for Python scriptsJohan Herland, Aug 12, 2009
  3. 2/4 Add Python support library for CVS remote helperJohan Herland, Aug 12, 2009
  4. David AguilarAug 12, 2009
  5. Johan HerlandAug 12, 2009
  6. Sverre RabbelierAug 12, 2009
  7. Michael HaggertyAug 13, 2009
  8. Johan HerlandAug 13, 2009
  9. Junio C HamanoAug 13, 2009
  10. Johan HerlandAug 13, 2009
  11. Junio C HamanoAug 16, 2009
  12. 1/2 git_remote_cvs: Honor DESTDIR in the MakefileDavid Aguilar, Aug 16, 2009
  13. 2/2 git_remote_cvs: Use $(shell) in the MakefileDavid Aguilar, Aug 16, 2009
  14. David AguilarAug 16, 2009
  15. Johannes SchindelinAug 16, 2009
  16. David AguilarAug 16, 2009
  17. Johannes SchindelinAug 16, 2009
  18. Johan HerlandAug 17, 2009
  19. 1/2 git_remote_cvs: Honor DESTDIR in the MakefileDavid Aguilar, Aug 16, 2009
  20. 2/2 git_remote_cvs: Use $(shell) in the MakefileDavid Aguilar, Aug 16, 2009
  21. 3/4 Third draft of CVS remote helper programJohan Herland, Aug 12, 2009
  22. 4/4 Add simple selftests of git-remote-cvs functionalityJohan Herland, Aug 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.