git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 13/13] rebase -i: use "git sequencer--helper --cherry-pick"

From
Christian Couder <chriscool@tuxfamily.org>
Date
Aug 12, 2009, 05:15 UTC
Message-ID
<20090812051552.18155.74239.chriscool@tuxfamily.org>
In-Reply-To
<20090812051116.18155.70541.chriscool@tuxfamily.org>

instead of "git cherry-pick", as this will make it easier to port "git-rebase--interactive.sh" to C.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 git-rebase--interactive.sh |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 7651fd6..30af512 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -147,7 +147,7 @@ pick_one () {
 		pick_one_preserving_merges "$@" && return
 	if test ! -z "$REBASE_ROOT"
 	then
-		output git cherry-pick "$@"
+		git sequencer--helper --cherry-pick $sha1 $no_ff
 		return
 	fi
 	parent_sha1=$(git rev-parse --verify $sha1^) ||
@@ -157,7 +157,7 @@ pick_one () {
 		git sequencer--helper --fast-forward $sha1 \
 			"$GIT_REFLOG_ACTION" "$VERBOSE"
 	else
-		output git cherry-pick "$@"
+		git sequencer--helper --cherry-pick $sha1 $no_ff
 	fi
 }
 
@@ -269,7 +269,9 @@ pick_one_preserving_merges () {
 			fi
 			;;
 		*)
-			output git cherry-pick "$@" ||
+			no_commit=
+			test "a$1" = "a-n" && no_commit=t
+			git sequencer--helper --cherry-pick $sha1 $no_commit ||
 				die_with_patch $sha1 "Could not pick $sha1"
 			;;
 		esac
-- 
1.6.4.271.ge010d
Previous: Christian CouderNext: Junio C Hamano
Message 14 of 15 in “more changes to port rebase -i to C using sequencer code”
  1. 00/13 more changes to port rebase -i to C using sequencer codeChristian Couder, Aug 12, 2009
  2. 01/13 sequencer: add "do_fast_forward()" to perform a fast forwardChristian Couder, Aug 12, 2009
  3. 02/13 sequencer: add "--fast-forward" option to "git sequencer--helper"Christian Couder, Aug 12, 2009
  4. 03/13 sequencer: let "git sequencer--helper" callers set "allow_dirty"Christian Couder, Aug 12, 2009
  5. 04/13 rebase -i: use "git sequencer--helper --fast-forward"Christian Couder, Aug 12, 2009
  6. 05/13 revert: libify pickChristian Couder, Aug 12, 2009
  7. 06/13 pick: simplify "error(...)" followed by "return -1"Christian Couder, Aug 12, 2009
  8. 07/13 pick: rename "pick()" to "pick_commit()"Christian Couder, Aug 12, 2009
  9. 08/13 pick: remove useless PICK_REVERSE => PICK_ADD_NOTE codeChristian Couder, Aug 12, 2009
  10. 09/13 pick: simplify bogus comment about commiting immediatelyChristian Couder, Aug 12, 2009
  11. 10/13 pick: libify "pick_help_msg()"Christian Couder, Aug 12, 2009
  12. 11/13 sequencer: add "do_commit()" and related functionsChristian Couder, Aug 12, 2009
  13. 12/13 sequencer: add "--cherry-pick" option to "git sequencer--helper"Christian Couder, Aug 12, 2009
  14. 13/13 rebase -i: use "git sequencer--helper --cherry-pick"Christian Couder, Aug 12, 2009
  15. Junio C HamanoAug 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.