git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 08/13] pick: remove useless PICK_REVERSE => PICK_ADD_NOTE code

From
Christian Couder <chriscool@tuxfamily.org>
Date
Aug 12, 2009, 05:15 UTC
Message-ID
<20090812051552.18155.22076.chriscool@tuxfamily.org>
In-Reply-To
<20090812051116.18155.70541.chriscool@tuxfamily.org>
Useless of the removed code was found by Junio.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 pick.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/pick.c b/pick.c
index 13bf793..a6b1d6f 100644
--- a/pick.c
+++ b/pick.c
@@ -84,9 +84,6 @@ int pick_commit(struct commit *pick_commit, int mainline, int flags,
 	strbuf_init(msg, 0);
 	commit = pick_commit;
 
-	if (flags & PICK_REVERSE) /* REVERSE implies ADD_NOTE */
-		flags |= PICK_ADD_NOTE;
-
 	/*
 	 * We do not intend to commit immediately.  We just want to
 	 * merge the differences in, so let's compute the tree
-- 
1.6.4.271.ge010d
Previous: Christian CouderNext: Christian Couder
Message 9 of 15 in “more changes to port rebase -i to C using sequencer code”
  1. 00/13 more changes to port rebase -i to C using sequencer codeChristian Couder, Aug 12, 2009
  2. 01/13 sequencer: add "do_fast_forward()" to perform a fast forwardChristian Couder, Aug 12, 2009
  3. 02/13 sequencer: add "--fast-forward" option to "git sequencer--helper"Christian Couder, Aug 12, 2009
  4. 03/13 sequencer: let "git sequencer--helper" callers set "allow_dirty"Christian Couder, Aug 12, 2009
  5. 04/13 rebase -i: use "git sequencer--helper --fast-forward"Christian Couder, Aug 12, 2009
  6. 05/13 revert: libify pickChristian Couder, Aug 12, 2009
  7. 06/13 pick: simplify "error(...)" followed by "return -1"Christian Couder, Aug 12, 2009
  8. 07/13 pick: rename "pick()" to "pick_commit()"Christian Couder, Aug 12, 2009
  9. 08/13 pick: remove useless PICK_REVERSE => PICK_ADD_NOTE codeChristian Couder, Aug 12, 2009
  10. 09/13 pick: simplify bogus comment about commiting immediatelyChristian Couder, Aug 12, 2009
  11. 10/13 pick: libify "pick_help_msg()"Christian Couder, Aug 12, 2009
  12. 11/13 sequencer: add "do_commit()" and related functionsChristian Couder, Aug 12, 2009
  13. 12/13 sequencer: add "--cherry-pick" option to "git sequencer--helper"Christian Couder, Aug 12, 2009
  14. 13/13 rebase -i: use "git sequencer--helper --cherry-pick"Christian Couder, Aug 12, 2009
  15. Junio C HamanoAug 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.