git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 07/13] pick: rename "pick()" to "pick_commit()"

From
Christian Couder <chriscool@tuxfamily.org>
Date
Aug 12, 2009, 05:15 UTC
Message-ID
<20090812051552.18155.44080.chriscool@tuxfamily.org>
In-Reply-To
<20090812051116.18155.70541.chriscool@tuxfamily.org>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 builtin-revert.c |    2 +-
 pick.c           |    8 ++++----
 pick.h           |    2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/builtin-revert.c b/builtin-revert.c
index 6dd29a3..4797ac5 100644
--- a/builtin-revert.c
+++ b/builtin-revert.c
@@ -206,7 +206,7 @@ static int revert_or_cherry_pick(int argc, const char **argv)
 					git_commit_encoding, encoding)))
 		commit->buffer = reencoded_message;
 
-	failed = pick(commit, mainline, flags, &msgbuf);
+	failed = pick_commit(commit, mainline, flags, &msgbuf);
 	if (failed < 0) {
 		exit(1);
 	} else if (failed > 0) {
diff --git a/pick.c b/pick.c
index 6fea39c..13bf793 100644
--- a/pick.c
+++ b/pick.c
@@ -60,16 +60,16 @@ static struct tree *empty_tree(void)
 }
 
 /*
- * Pick changes introduced by pick_commit into current working tree
- * and index.
+ * Pick changes introduced by "commit" argument into current working
+ * tree and index.
  *
  * Return 0 on success.
  * Return negative value on error before picking,
  * and a positive value after picking,
  * and return 1 if and only if a conflict occurs but no other error.
  */
-int pick(struct commit *pick_commit, int mainline, int flags,
-						struct strbuf *msg)
+int pick_commit(struct commit *pick_commit, int mainline, int flags,
+		struct strbuf *msg)
 {
 	unsigned char head[20];
 	struct commit *base, *next, *parent;
diff --git a/pick.h b/pick.h
index 7eb0d3a..7a74ad8 100644
--- a/pick.h
+++ b/pick.h
@@ -8,6 +8,6 @@
 #define PICK_ADD_NOTE  2 /* add note about original commit (unless conflict) */
 /* We don't need a PICK_QUIET. This is done by
  *	setenv("GIT_MERGE_VERBOSITY", "0", 1); */
-extern int pick(struct commit *pick_commit, int mainline, int flags, struct strbuf *msg);
+extern int pick_commit(struct commit *commit, int mainline, int flags, struct strbuf *msg);
 
 #endif
-- 
1.6.4.271.ge010d
Previous: Christian CouderNext: Christian Couder
Message 8 of 15 in “more changes to port rebase -i to C using sequencer code”
  1. 00/13 more changes to port rebase -i to C using sequencer codeChristian Couder, Aug 12, 2009
  2. 01/13 sequencer: add "do_fast_forward()" to perform a fast forwardChristian Couder, Aug 12, 2009
  3. 02/13 sequencer: add "--fast-forward" option to "git sequencer--helper"Christian Couder, Aug 12, 2009
  4. 03/13 sequencer: let "git sequencer--helper" callers set "allow_dirty"Christian Couder, Aug 12, 2009
  5. 04/13 rebase -i: use "git sequencer--helper --fast-forward"Christian Couder, Aug 12, 2009
  6. 05/13 revert: libify pickChristian Couder, Aug 12, 2009
  7. 06/13 pick: simplify "error(...)" followed by "return -1"Christian Couder, Aug 12, 2009
  8. 07/13 pick: rename "pick()" to "pick_commit()"Christian Couder, Aug 12, 2009
  9. 08/13 pick: remove useless PICK_REVERSE => PICK_ADD_NOTE codeChristian Couder, Aug 12, 2009
  10. 09/13 pick: simplify bogus comment about commiting immediatelyChristian Couder, Aug 12, 2009
  11. 10/13 pick: libify "pick_help_msg()"Christian Couder, Aug 12, 2009
  12. 11/13 sequencer: add "do_commit()" and related functionsChristian Couder, Aug 12, 2009
  13. 12/13 sequencer: add "--cherry-pick" option to "git sequencer--helper"Christian Couder, Aug 12, 2009
  14. 13/13 rebase -i: use "git sequencer--helper --cherry-pick"Christian Couder, Aug 12, 2009
  15. Junio C HamanoAug 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.