git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH v2] FindBugs: don't use new String(String) in RefDatabase

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Jul 21, 2009, 14:50 UTC
Message-ID
<200907211650.36831.robin.rosenberg.lists@dewire.com>
In-Reply-To
<20090713145308.GI11191@spearce.org>
måndag 13 juli 2009 16:53:08 skrev "Shawn O. Pearce" <spearce@spearce.org>:
Show 7 quoted lines
>  Yann Simon <yann.simon.fr@gmail.com> wrote:
>  > This method is quite clear.
>  > One line javadoc would make it even clearer... :p (and maybe make Robin happy)
>  
>  Javadoc is overrated.  Private utility methods like this that are one
>  line long don't need documentation.  The rationale for why this line
>  does what it does is something that `git blame` can answer better.

Sorry Yann, I'm with Shawn here. A comment wouldn't add anything here since the method is pretty simple. Besides javadocs are for API's so an inline comment would be better, but I don't think it is necessary.

Shawn, any references for the ability of JIT's abilities to stack allocate in this context? For me learning, will commit anyway.

-- robina
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 8 of 10 in “Method invokes inefficient new String(String) constructor”
  1. Method invokes inefficient new String(String) constructorYann Simon, Mar 19, 2009
  2. Shawn O. PearceMar 19, 2009
  3. Yann SimonMar 19, 2009
  4. Yann SimonJul 9, 2009
  5. FindBugs: don't use new String(String) in RefDatabaseShawn O. Pearce, Jul 10, 2009
  6. Yann SimonJul 13, 2009
  7. FindBugs: don't use new String(String) in RefDatabaseShawn O. Pearce, Jul 13, 2009
  8. Robin RosenbergJul 21, 2009
  9. Shawn O. PearceJul 21, 2009
  10. Robin RosenbergJul 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.