[PATCH JGIT] Method invokes inefficient new String(String) constructor
- From
Yann Simon <yann.simon.fr@gmail.com>
- Date
- Mar 19, 2009, 09:15 UTC
- Message-ID
- <49C20D4E.5020203@gmail.com>
>From FindBugs:
Using the java.lang.String(String) constructor wastes memory because the object so constructed will be functionally indistinguishable from the String passed as a parameter. Just use the argument String directly.
Signed-off-by: Yann Simon <yann.simon.fr@gmail.com> --- .../src/org/spearce/jgit/lib/RefDatabase.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java b/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java index 87f26bf..49da538 100644 --- a/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/RefDatabase.java @@ -447,7 +447,7 @@ private synchronized void refreshPackedRefs() { final int sp = p.indexOf(' '); final ObjectId id = ObjectId.fromString(p.substring(0, sp)); - final String name = new String(p.substring(sp + 1)); + final String name = p.substring(sp + 1); last = new Ref(Ref.Storage.PACKED, name, name, id); newPackedRefs.put(last.getName(), last); }
-- 1.6.1.2