From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Tue, 21 Jul 2009 14:50:36 GMT
Subject: Re: [JGIT PATCH v2] FindBugs: don't use new String(String) in RefDatabase
Message-ID: <200907211650.36831.robin.rosenberg.lists@dewire.com>
In-Reply-To: <20090713145308.GI11191@spearce.org>

måndag 13 juli 2009 16:53:08 skrev "Shawn O. Pearce" <spearce@spearce.org>:
>  Yann Simon <yann.simon.fr@gmail.com> wrote:
>  > This method is quite clear.
>  > One line javadoc would make it even clearer... :p (and maybe make Robin happy)
>  
>  Javadoc is overrated.  Private utility methods like this that are one
>  line long don't need documentation.  The rationale for why this line
>  does what it does is something that `git blame` can answer better.

Sorry Yann, I'm with Shawn here. A comment wouldn't add anything here since
the method is pretty simple. Besides javadocs are for API's so an inline comment
would be better, but I don't think it is necessary.

Shawn, any references for the ability of JIT's abilities to stack allocate in this context? For
me learning, will commit anyway.

-- robina