git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] gitweb: Use "previous" header of git-blame -p in 'blame' view

From
Jakub Narebski <jnareb@gmail.com>
Date
Jul 14, 2009, 19:21 UTC
Message-ID
<200907142121.31012.jnareb@gmail.com>
In-Reply-To
<200907102357.43475.jnareb@gmail.com>
On Fri, 10 July 2009, Jakub Narebski wrote:
Show 9 quoted lines
> +# if filename is surrounded in double quotes, it need to be unquoted
> +sub unquote_maybe {
> +       my $str = shift;
> +
> +       if ($str =~ /^"(.*)"$/) {
> +               return unquote($1);
> +       }
> +       return $str;
> +}

I'm sorry about that, but this is totally unnecessary, as unquote == unquote_maybe (unquotes only when necessary).

-- 
Jakub Narebski
Poland
Previous: Luben TuikovNext: Jakub Narebski
Message 7 of 11 in “gitweb: 'blame' view improvements”
  1. 0/3 gitweb: 'blame' view improvementsJakub Narebski, Jul 10, 2009
  2. 1/3 gitweb: Mark boundary commits in 'blame' viewJakub Narebski, Jul 10, 2009
  3. 2/3 gitweb: Use "previous" header of git-blame -p in 'blame' viewJakub Narebski, Jul 10, 2009
  4. Junio C HamanoJul 10, 2009
  5. Jakub NarebskiJul 11, 2009
  6. Luben TuikovJul 12, 2009
  7. Jakub NarebskiJul 14, 2009
  8. 3/3 gitweb: Add author initials in 'blame' view, a la "git gui blame"Jakub Narebski, Jul 10, 2009
  9. Jakub NarebskiJul 11, 2009
  10. 5/3 gitweb: Incremental blame (proof of concept)Jakub Narebski, Jul 13, 2009
  11. 4/3 gitweb: Use light/dark class also in 'blame' viewJakub Narebski, Jul 12, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.