From: Jakub Narebski Date: Tue, 14 Jul 2009 19:21:29 GMT Subject: Re: [PATCH 2/3] gitweb: Use "previous" header of git-blame -p in 'blame' view Message-ID: <200907142121.31012.jnareb@gmail.com> In-Reply-To: <200907102357.43475.jnareb@gmail.com> On Fri, 10 July 2009, Jakub Narebski wrote: > +# if filename is surrounded in double quotes, it need to be unquoted > +sub unquote_maybe { > +       my $str = shift; > + > +       if ($str =~ /^"(.*)"$/) { > +               return unquote($1); > +       } > +       return $str; > +} I'm sorry about that, but this is totally unnecessary, as unquote == unquote_maybe (unquotes only when necessary). -- Jakub Narebski Poland