Re: [PATCH 2/3] gitweb: Use "previous" header of git-blame -p in 'blame' view

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 10, 2009, 22:21 UTC
Message-ID: <7v4otkuqlq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200907102357.43475.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 7 quoted lines

> Luben Tuikov changed 'lineno' link (line number link) from pointing to
> 'blame' view at given line at blamed commit, to the one at parent of
> blamed commit in
>   244a70e (Blame "linenr" link jumps to previous state at
>            "orig_lineno", 2007-01-04).
> This made it possible to do data mining using 'blame' view, by going
> through history of a line using mentioned line number link.

I was playing with this feature the other day (and I think you can guess what I was writing when I was doing so as preparation). I was mildly annoyed that these links on the commit object names go to the commit view.

I think going to commitdiff view would make it far more useful while digging.

Suppose if you were somehow interested in the recent commit by Peff, "Makefile: install 'git' in execdir". You go to:

    http://repo.or.cz/w/alt-git.git

and look at commitdiff of the commit from the shortlog part.

You read the diff, understand what the changed Makefile does, but you get curious to see the blame. Nicely, the commitdiff view has a list of the files changed, and each entry in the list has "blame" link.

Clicking it would give you the blame on each line from the Makefile.

So far, very smooth experience. Then you scroll to an area of the file you are interested in, and click on one of the commits.

Oops.

It does not show the change of the commit made by this one, even though it does list Makefile in the list of files changed, and it has a blame link, the commit view without diff disrupts the thought process I had in the previous blame page, and I have to go to commitdiff to reorient myself.