[PATCH 4/4] gitweb: Remove unused $hash_base parameter from normalize_link_target
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- May 11, 2009, 17:45 UTC
- Message-ID
- <20090511174253.15152.8987.stgit@localhost.localdomain>
- In-Reply-To
- <20090511173025.15152.94215.stgit@localhost.localdomain>
...since it was decided for normalize_link_target to only mangle pathname, and do not try to check if target is present in $hash_base tree, for performance reasons.
Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- This was caugth by Perl::Critic::Policy::Variables::ProhibitReusedNames - Do not reuse a variable name in a lexical scope.
(That was probably me that forgot to remove parameter, but I didn't search for authorship of this fragment.)
gitweb/gitweb.perl | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index c72ae10..05702e4 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3339,10 +3339,7 @@ sub git_get_link_target { # return target of link relative to top directory (top tree); # return undef if it is not possible (including absolute links). sub normalize_link_target { - my ($link_target, $basedir, $hash_base) = @_; - - # we can normalize symlink target only if $hash_base is provided - return unless $hash_base; + my ($link_target, $basedir) = @_; # absolute symlinks (beginning with '/') cannot be normalized return if (substr($link_target, 0, 1) eq '/'); @@ -3398,7 +3395,7 @@ sub git_print_tree_entry { if (S_ISLNK(oct $t->{'mode'})) { my $link_target = git_get_link_target($t->{'hash'}); if ($link_target) { - my $norm_target = normalize_link_target($link_target, $basedir, $hash_base); + my $norm_target = normalize_link_target($link_target, $basedir); if (defined $norm_target) { print " -> " . $cgi->a({-href => href(action=>"object", hash_base=>$hash_base,