git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] gitweb: Some code cleanups, part 2 (low hanging fruit)

From
Jakub Narebski <jnareb@gmail.com>
Date
May 11, 2009, 17:36 UTC
Message-ID
<20090511173025.15152.94215.stgit@localhost.localdomain>

The following series was inspired by severity: 3 Perl::Critic (http://perlcritic.com) suggestions for gitweb; the patches listed below are simple and obvious fixes. That is why there is no detailed explanation of perlcritic policy for each patch.

This time I have checked that t9500 passes...
---
Jakub Narebski (4):
  gitweb: Remove unused $hash_base parameter from normalize_link_target
  gitweb: Simplify snapshot format detection logic in evaluate_path_info
  gitweb: Use capturing parentheses only when you intend to capture
  gitweb: Replace wrongly added tabs with spaces
 gitweb/gitweb.perl |   20 +++++++++-----------
 1 files changed, 9 insertions(+), 11 deletions(-)
-- 
Jakub Narebski
ShadeHawk on #git
Poland
Next: Jakub Narebski
Message 1 of 6 in “gitweb: Some code cleanups, part 2 (low hanging fruit)”
  1. 0/4 gitweb: Some code cleanups, part 2 (low hanging fruit)Jakub Narebski, May 11, 2009
  2. 1/4 gitweb: Replace wrongly added tabs with spacesJakub Narebski, May 11, 2009
  3. 2/4 gitweb: Use capturing parentheses only when you intend to captureJakub Narebski, May 11, 2009
  4. 3/4 gitweb: Simplify snapshot format detection logic in evaluate_path_infoJakub Narebski, May 11, 2009
  5. Giuseppe BilottaMay 11, 2009
  6. 4/4 gitweb: Remove unused $hash_base parameter from normalize_link_targetJakub Narebski, May 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.