[PATCH 2/4] gitweb: Use capturing parentheses only when you intend to capture
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- May 11, 2009, 17:39 UTC
- Message-ID
- <20090511173733.15152.83661.stgit@localhost.localdomain>
- In-Reply-To
- <20090511173025.15152.94215.stgit@localhost.localdomain>
Non-capturing groups are useful because they have better runtime performance and do not copy strings to the magic global capture variables.
Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- "Perl Best Practices", section 12.14. Capturing Parentheses (Use capturing parentheses only when you intend to capture.)
gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index beb79ee..097bd18 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -828,7 +828,7 @@ if (!defined $action) { if (!defined($actions{$action})) { die_error(400, "Unknown action"); } -if ($action !~ m/^(opml|project_list|project_index)$/ && +if ($action !~ m/^(?:opml|project_list|project_index)$/ && !$project) { die_error(400, "Project needed"); }