git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: use --textconv to generate diff text

From
Jeff King <peff@peff.net>
Date
May 11, 2009, 09:13 UTC
Message-ID
<20090511091346.GA5685@coredump.intra.peff.net>
In-Reply-To
<4A07D160.9020709@viscovery.net>
On Mon, May 11, 2009 at 09:18:56AM +0200, Johannes Sixt wrote:
Show 9 quoted lines
> For the most part gitk's focus is on showing history and changes in
> a human readable form. For this reason, it makes sense to generate
> the patch text in the diff view using --textconv so that textconv drivers
> are used if they are defined.
> 
> gitk can also generate patches, but we do not use --textconv because
> such patches could not be applied.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>

As the original author of the textconv code, I am in favor of this. So much so that I even posted basically the same patch before:

  http://article.gmane.org/gmane.comp.version-control.git/102523

I had trouble finding much discussion in the archive, but I think it may not have been taken because we were in release freeze (and textconv was a brand new feature in the release at the time).

-Peff
Previous: Johannes SixtNext: Junio C Hamano
Message 3 of 6 in “gitk: use --textconv to generate diff text”
  1. gitk: use --textconv to generate diff textJohannes Sixt, May 11, 2009
  2. Johannes SixtMay 11, 2009
  3. Jeff KingMay 11, 2009
  4. Junio C HamanoMay 11, 2009
  5. Paul MackerrasMay 11, 2009
  6. Jeff KingMay 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.