git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitk: use --textconv to generate diff text

From
Johannes Sixt <j.sixt@viscovery.net>
Date
May 11, 2009, 07:18 UTC
Message-ID
<4A07D160.9020709@viscovery.net>
From: Johannes Sixt <j6t@kdbg.org>
Date: Tue, 28 Apr 2009 14:03:54 +0200

For the most part gitk's focus is on showing history and changes in a human readable form. For this reason, it makes sense to generate the patch text in the diff view using --textconv so that textconv drivers are used if they are defined.

gitk can also generate patches, but we do not use --textconv because such patches could not be applied.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 gitk-git/gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 09eac46..a8a6022 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -7194,7 +7194,7 @@ proc getblobdiffs {ids} {
     global limitdiffs vfilelimit curview
     global diffencoding targetline diffnparents

-    set cmd [diffcmd $ids "-p -C --cc --no-commit-id -U$diffcontext"]
+    set cmd [diffcmd $ids "-p --textconv -C --cc --no-commit-id -U$diffcontext"]
     if {$ignorespace} {
 	append cmd " -w"
     }
-- 
1.6.3.1007.g03ec
Next: Johannes Sixt
Message 1 of 6 in “gitk: use --textconv to generate diff text”
  1. gitk: use --textconv to generate diff textJohannes Sixt, May 11, 2009
  2. Johannes SixtMay 11, 2009
  3. Jeff KingMay 11, 2009
  4. Junio C HamanoMay 11, 2009
  5. Paul MackerrasMay 11, 2009
  6. Jeff KingMay 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.