From: Jeff King <peff@peff.net>
Date: Mon, 11 May 2009 09:13:47 GMT
Subject: Re: [PATCH] gitk: use --textconv to generate diff text
Message-ID: <20090511091346.GA5685@coredump.intra.peff.net>
In-Reply-To: <4A07D160.9020709@viscovery.net>

On Mon, May 11, 2009 at 09:18:56AM +0200, Johannes Sixt wrote:

> For the most part gitk's focus is on showing history and changes in
> a human readable form. For this reason, it makes sense to generate
> the patch text in the diff view using --textconv so that textconv drivers
> are used if they are defined.
> 
> gitk can also generate patches, but we do not use --textconv because
> such patches could not be applied.
> 
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>

As the original author of the textconv code, I am in favor of this. So
much so that I even posted basically the same patch before:

  http://article.gmane.org/gmane.comp.version-control.git/102523

I had trouble finding much discussion in the archive, but I think it may
not have been taken because we were in release freeze (and textconv was
a brand new feature in the release at the time).

-Peff