Re: [PATCH] topgit tg push feature
- From
- martin f krafft <madduck@madduck.net>
- Date
- May 11, 2009, 07:47 UTC
- Message-ID
- <20090511074731.GA30271@lapse.rw.madduck.net>
- In-Reply-To
- <20090511032813.GA15540@gmx.de>
also sprach Marc Weber <marco-oweber@gmx.de> [2009.05.11.0528 +0200]:
Show 9 quoted lines
> commit cdab940eefc0a56e0daa8b270bace1aba00a3b57 > Author: Marc Weber <marco-oweber@gmx.de> > Date: Mon May 11 05:25:40 2009 +0200 > > t/tg-push > > add tg-push pushing the branch, its deps and their bases > > Signed-off-by: Marc Weber <marco-oweber@gmx.de>
I tested this feature and it seems to work quite nicely. I have a couple of minor remarks, but otherwise am ready to sign this off and include it upstream.
As soon as this feature is there, we need to disable to push refspecs installed by tg-remote, and also probably add a warning to the hook in case they are present; those are evil.
> + -h|--help) > + echo "Usage: tg push [(--dry-run | --no-deps | --tgish-only)] [-r "remote remote2"]* branch*" > + exit 1;;
--help should not exit non-zero, because if you ask for --help and it prints it, that's not an error.
> +if [ -z "$remotes" ]; then > + remotes="$(git config topgit.remote 2>/dev/null)" > +fi
This configuration key was news to me, but only because I usually run tg-remote without --populate, in which case it is not added. This is probably a bug in tg-remote and should be fixed alongside the push refspec removal.
Show 6 quoted lines
> + echo "pushing:"; echo $list > + if $dry_run; then > + echo git push $remote $list > + else > + git push $remote $list > + fi
git-push has --dry-run, why not use that?
-- martin | http://madduck.net/ | http://two.sentenc.es/ due to lack of interest tomorrow has been cancelled. spamtraps: madduck.bogus@madduck.net