git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t5505-remote fails on Windows

From
Jeff King <peff@peff.net>
Date
Mar 19, 2009, 05:03 UTC
Message-ID
<20090319050328.GA9746@coredump.intra.peff.net>
In-Reply-To
<76718490903182156y3b2b9d8aw708829a6ed151aa@mail.gmail.com>
On Thu, Mar 19, 2009 at 12:56:37AM -0400, Jay Soffian wrote:
Show 7 quoted lines
> > As a side note, I find this solution a little bit ugly. String lists
> > should sort on their strings, not on some other random magic in the util
> > field. This usage really abuses string_list a bit as a data type because
> > we have no generic "list" type.
> 
> I really don't think so. The string_list API accommodates this case
> quite nicely. So why not?

I think the code would be more natural as a list of structs, each with a source and dest. But C does not make it pleasant to write generic data types, so things end up stuffed into string_lists with a magic util field. So I think leaving it as a string_list is probably the most sane thing to do.

-Peff
Previous: Jay SoffianNext: Johannes Sixt
Message 5 of 18 in “t5505-remote fails on Windows”
  1. Johannes SixtMar 18, 2009
  2. Jeff KingMar 19, 2009
  3. Jeff KingMar 19, 2009
  4. Jay SoffianMar 19, 2009
  5. Jeff KingMar 19, 2009
  6. Johannes SixtMar 19, 2009
  7. Jeff KingMar 19, 2009
  8. Johannes SchindelinMar 19, 2009
  9. Junio C HamanoMar 19, 2009
  10. Jay SoffianMar 19, 2009
  11. Jeff KingMar 19, 2009
  12. Johannes SchindelinMar 19, 2009
  13. remote: improve sorting of "configure for git push" listJeff King, Mar 22, 2009
  14. Jay SoffianMar 22, 2009
  15. Junio C HamanoMar 22, 2009
  16. Johannes SixtMar 23, 2009
  17. Junio C HamanoMar 23, 2009
  18. Jeff KingMar 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.