From: Jeff King <peff@peff.net>
Date: Thu, 19 Mar 2009 05:03:28 GMT
Subject: Re: t5505-remote fails on Windows
Message-ID: <20090319050328.GA9746@coredump.intra.peff.net>
In-Reply-To: <76718490903182156y3b2b9d8aw708829a6ed151aa@mail.gmail.com>

On Thu, Mar 19, 2009 at 12:56:37AM -0400, Jay Soffian wrote:

> > As a side note, I find this solution a little bit ugly. String lists
> > should sort on their strings, not on some other random magic in the util
> > field. This usage really abuses string_list a bit as a data type because
> > we have no generic "list" type.
> 
> I really don't think so. The string_list API accommodates this case
> quite nicely. So why not?

I think the code would be more natural as a list of structs, each with a
source and dest. But C does not make it pleasant to write generic data
types, so things end up stuffed into string_lists with a magic util
field. So I think leaving it as a string_list is probably the most sane
thing to do.

-Peff