Re: t5505-remote fails on Windows

From: Jeff King <peff@peff.net>
Date: Mar 19, 2009, 19:52 UTC
Message-ID: <20090319195254.GA17028@coredump.intra.peff.net>
In-Reply-To: <alpine.DEB.1.00.0903191135530.10279@pacific.mpi-cbg.de>

On Thu, Mar 19, 2009 at 11:36:50AM +0100, Johannes Schindelin wrote:

Show 9 quoted lines

> > +void sort_string_list_with_fn(struct string_list *list,
> > +			      int (*fn)(const void *, const void *))
> > +{
> > +	qsort(list->items, list->nr, sizeof(*list->items), fn);
> > +}
> > +
> 
> Do we really want an API for that?  Calling qsort() directly should be 
> obvious enough, no?

I'm fine with that, too. I was just encapsulating out of habit. But if it is normal to peek directly at list->nr and list->items, then calling qsort directly is fine.

-Peff