Re: [JGIT PATCH 6/5 v2] Add tests for RevWalk and its supporting code
- From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
- Date
- Mar 15, 2009, 11:34 UTC
- Message-ID
- <200903151234.36812.robin.rosenberg.lists@dewire.com>
- In-Reply-To
- <20090314005617.GK22920@spearce.org>
A few /09 interesting/ places in StartGenerator are not covered by the tests.
if (q instanceof DateRevQueue) pending = (DateRevQueue)q; else --> pending = new DateRevQueue(q);
and
if (tf != TreeFilter.ALL) {
--> rf = AndRevFilter.create(rf, new RewriteTreeFilter(w, tf));
--> pendingOutputType |= HAS_REWRITE | NEEDS_REWRITE;
}PendingGenerator
if (n != null && n.commitTime >= last.commitTime) {
// This is too close to call. The next commit we
// would pop is dated after the last one produced.
// We have to keep going to ensure that we carry
// flags as much as necessary.
//
--> overScan = OVER_SCAN;I'll merge it anyway since this is still a huge improvement compared to the previous state.
-- robin