git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[JGIT PATCH 0/5] RevWalk fixes for UNINTERESTING

From
Shawn O. Pearce <spearce@spearce.org>
Date
Mar 13, 2009, 02:07 UTC
Message-ID
<1236910062-18476-1-git-send-email-spearce@spearce.org>

Today I uncovered some ugly cases with "jgit rev-list B ^A", where some commits reachable from A were still being output, even though we asked that they be excluded.

This series attempts to fix it by forcing date ordering, and delaying output a little to try and work over any clock skew discovered near the end of the traversal, just before we give up.

Shawn O. Pearce (5):
  Show critical flags in debug toString() descriptions of rev queues
  Make RevObject.getType implementations final
  Remove the horribly stupid RevSort.START_ORDER
  Fix RevWalk with Linus Torvald's occasional bad commit date hack
  Avoid incorrect output of UNINTERESTING commits when clock skew
    occurs
 .../org/spearce/jgit/revwalk/AbstractRevQueue.java |    5 +
 .../src/org/spearce/jgit/revwalk/DateRevQueue.java |   10 +--
 .../org/spearce/jgit/revwalk/DelayRevQueue.java    |   92 ++++++++++++++++++++
 .../src/org/spearce/jgit/revwalk/FIFORevQueue.java |   10 +--
 .../jgit/revwalk/FixUninterestingGenerator.java    |   77 ++++++++++++++++
 .../src/org/spearce/jgit/revwalk/LIFORevQueue.java |   10 +--
 .../org/spearce/jgit/revwalk/PendingGenerator.java |   59 +++++++++++--
 .../src/org/spearce/jgit/revwalk/RevBlob.java      |    2 +-
 .../src/org/spearce/jgit/revwalk/RevCommit.java    |   15 +++-
 .../src/org/spearce/jgit/revwalk/RevObject.java    |   24 +++++
 .../src/org/spearce/jgit/revwalk/RevSort.java      |   11 ---
 .../src/org/spearce/jgit/revwalk/RevTag.java       |    2 +-
 .../src/org/spearce/jgit/revwalk/RevTree.java      |    2 +-
 .../src/org/spearce/jgit/revwalk/RevWalk.java      |    6 +-
 .../org/spearce/jgit/revwalk/StartGenerator.java   |   27 ++++--
 15 files changed, 296 insertions(+), 56 deletions(-)
 create mode 100644 org.spearce.jgit/src/org/spearce/jgit/revwalk/DelayRevQueue.java
 create mode 100644 org.spearce.jgit/src/org/spearce/jgit/revwalk/FixUninterestingGenerator.java
Next: Shawn O. Pearce
Message 1 of 13 in “RevWalk fixes for UNINTERESTING”
  1. 0/5 RevWalk fixes for UNINTERESTINGShawn O. Pearce, Mar 13, 2009
  2. 1/5 Show critical flags in debug toString() descriptions of rev queuesShawn O. Pearce, Mar 13, 2009
  3. 2/5 Make RevObject.getType implementations finalShawn O. Pearce, Mar 13, 2009
  4. 3/5 Remove the horribly stupid RevSort.START_ORDERShawn O. Pearce, Mar 13, 2009
  5. 4/5 Fix RevWalk with Linus Torvald's occasional bad commit date hackShawn O. Pearce, Mar 13, 2009
  6. 5/5 Avoid incorrect output of UNINTERESTING commits when clock skew occursShawn O. Pearce, Mar 13, 2009
  7. 4/5 Fix RevWalk with Linus Torvald's occasional bad commit date hackShawn O. Pearce, Mar 14, 2009
  8. Robin RosenbergMar 13, 2009
  9. 0/6 Add tests for RevWalk and its supporting codeShawn O. Pearce, Mar 13, 2009
  10. Shawn O. PearceMar 14, 2009
  11. 6/5 Add tests for RevWalk and its supporting codeShawn O. Pearce, Mar 14, 2009
  12. Robin RosenbergMar 15, 2009
  13. Shawn O. PearceMar 16, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.