git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 0/6] Add tests for RevWalk and its supporting code

From
Shawn O. Pearce <spearce@spearce.org>
Date
Mar 14, 2009, 00:13 UTC
Message-ID
<20090314001345.GI22920@spearce.org>
In-Reply-To
<20090313223933.GH22920@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> wrote:
Show 15 quoted lines
> These new tests cover some of the common cases we see with using a
> RevWalk, and increase our code coverage in this critical area of
> the JGit library.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
>  Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
>  > fredag 13 mars 2009 03:07:37 skrev "Shawn O. Pearce" <spearce@spearce.org>:
>  > > Today I uncovered some ugly cases with "jgit rev-list B ^A", where
>  > > some commits reachable from A were still being output, even though
>  > > we asked that they be excluded.
>  > 
>  > How about a test suite to prove this is better than before?
> 
>  Its better.  :-)

Its actually not better. Although the tests I'm replying to are right, there's another bug introduced by this series that they don't detect, but that shows up on the Linux kernel repository.

I have yet to track down the full thing... but I know its busted.
 
-- 
Shawn.
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 10 of 13 in “RevWalk fixes for UNINTERESTING”
  1. 0/5 RevWalk fixes for UNINTERESTINGShawn O. Pearce, Mar 13, 2009
  2. 1/5 Show critical flags in debug toString() descriptions of rev queuesShawn O. Pearce, Mar 13, 2009
  3. 2/5 Make RevObject.getType implementations finalShawn O. Pearce, Mar 13, 2009
  4. 3/5 Remove the horribly stupid RevSort.START_ORDERShawn O. Pearce, Mar 13, 2009
  5. 4/5 Fix RevWalk with Linus Torvald's occasional bad commit date hackShawn O. Pearce, Mar 13, 2009
  6. 5/5 Avoid incorrect output of UNINTERESTING commits when clock skew occursShawn O. Pearce, Mar 13, 2009
  7. 4/5 Fix RevWalk with Linus Torvald's occasional bad commit date hackShawn O. Pearce, Mar 14, 2009
  8. Robin RosenbergMar 13, 2009
  9. 0/6 Add tests for RevWalk and its supporting codeShawn O. Pearce, Mar 13, 2009
  10. Shawn O. PearceMar 14, 2009
  11. 6/5 Add tests for RevWalk and its supporting codeShawn O. Pearce, Mar 14, 2009
  12. Robin RosenbergMar 15, 2009
  13. Shawn O. PearceMar 16, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.