git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Avoid segfault with 'git branch' when the HEAD is detached

From
Jeff King <peff@peff.net>
Date
Feb 19, 2009, 03:24 UTC
Message-ID
<20090219032420.GA26488@coredump.intra.peff.net>
In-Reply-To
<alpine.DEB.1.00.0902190212290.10279@pacific.mpi-cbg.de>
On Thu, Feb 19, 2009 at 02:15:00AM +0100, Johannes Schindelin wrote:
Show 8 quoted lines
> > Meaning that the bug was created after your valgrind testing (which 
> > takes a painfully long time to run, and so only happens occasionally), 
> > and therefore you found it by hand? Or meaning that even running the 
> > test suite with valgrind did not reveal the problem?
> 
> It bit me.
> 
> IOW I had to fix it before I could finish up the work for the day.

OK. I wasn't sure if it was "valgrind didn't find" or "valgrind wouldn't find". And your answer is "didn't", but as it turns out, it also "wouldn't.

Updated series with tests to follow.
-Peff
Previous: Johannes SchindelinNext: Jeff King
Message 5 of 12 in “Avoid segfault with 'git branch' when the HEAD is detached”
  1. Avoid segfault with 'git branch' when the HEAD is detachedJohannes Schindelin, Feb 18, 2009
  2. Jay SoffianFeb 18, 2009
  3. Jeff KingFeb 19, 2009
  4. Johannes SchindelinFeb 19, 2009
  5. Jeff KingFeb 19, 2009
  6. Jeff KingFeb 19, 2009
  7. 1/2 add basic branch display testsJeff King, Feb 19, 2009
  8. Jeff KingFeb 19, 2009
  9. Jay SoffianFeb 19, 2009
  10. Jeff KingFeb 19, 2009
  11. 2/2 branch: clean up repeated strlenJeff King, Feb 19, 2009
  12. Johannes SchindelinFeb 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.