Re: [PATCH 1/2] add basic branch display tests

From: Jay Soffian <jaysoffian@gmail.com>
Date: Feb 19, 2009, 03:51 UTC
Message-ID: <76718490902181951p54dc222ai5ac6397f3471fc44@mail.gmail.com>
In-Reply-To: <20090219034504.GA19862@coredump.intra.peff.net>

On Wed, Feb 18, 2009 at 10:45 PM, Jeff King <peff@peff.net> wrote:

Show 5 quoted lines

> But here we stick the "remotes/" head on, since we are showing both
> types. But the right hand side of the symref doesn't get the same
> treatment.
>
> I don't think it's a big deal, but I wasn't sure if it was intentional,

It was intentional on my part. I thought appending it a second time was redundant, and the remotes/ prefix on the LHS is just their to distinguish remote branches from local.

Show 10 quoted lines

> I also had a brief thought that reprinting the <remote> is pointless.
> That is, printing
>
>  origin/HEAD -> master
>
> shows what is happening with less text due to the context (i.e., we
> already know we are talking about remote "origin" -- and if it isn't in
> origin, we already show more). But that is probably a bad idea; that
> context is missing if you were to try to do something like "git show";
> <remote>/<branch> would work, but <branch> wouldn't.

Exactly. :-)

Thanks for the tests. If I had added them myself I wouldn't have you publicly questioning my intent. ;-)

j.