From: Jeff King Date: Thu, 19 Feb 2009 03:24:20 GMT Subject: Re: [PATCH] Avoid segfault with 'git branch' when the HEAD is detached Message-ID: <20090219032420.GA26488@coredump.intra.peff.net> In-Reply-To: On Thu, Feb 19, 2009 at 02:15:00AM +0100, Johannes Schindelin wrote: > > Meaning that the bug was created after your valgrind testing (which > > takes a painfully long time to run, and so only happens occasionally), > > and therefore you found it by hand? Or meaning that even running the > > test suite with valgrind did not reveal the problem? > > It bit me. > > IOW I had to fix it before I could finish up the work for the day. OK. I wasn't sure if it was "valgrind didn't find" or "valgrind wouldn't find". And your answer is "didn't", but as it turns out, it also "wouldn't. Updated series with tests to follow. -Peff