git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] filter-branch -d: Export GIT_DIR earlier

From
Lars Noschinski <lars@public.noschinski.de>
Date
Feb 16, 2009, 14:51 UTC
Message-ID
<20090216145137.GA4431@lars.home.noschinski.de>
In-Reply-To
<alpine.DEB.1.00.0902161441190.6289@intel-tinevez-2-302>
Hello,
* Johannes Schindelin <Johannes.Schindelin@gmx.de> [09-02-16 15:42]:
Show 8 quoted lines
>> This fix is not yet ready for commit, as it lacks a test case.
>> 
>> Writing a test case for this bug, I wonder about the preferred way to use a
>> directory outside any git repository in a test: Using some directory below
>> git/t/ will not work, as (in most cases) git is a git repository.
>
>How about using a filter-branch call with a filter that echoes GIT_DIR 
>into a file, then fails, and then checking the exact contents of GIT_DIR?

This would not catch this bug: for-each-ref is the only git command called after changing to the temporary directory and before exporting GIT_DIR.

It would help only if GIT_DIR would never be exported.
 - Lars.
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 3 of 5 in “filter-branch -d: Export GIT_DIR earlier”
  1. filter-branch -d: Export GIT_DIR earlierLars Noschinski, Feb 16, 2009
  2. Johannes SchindelinFeb 16, 2009
  3. Lars NoschinskiFeb 16, 2009
  4. Johannes SchindelinFeb 16, 2009
  5. Lars NoschinskiFeb 17, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.