From: Lars Noschinski <lars@public.noschinski.de>
Date: Mon, 16 Feb 2009 14:51:37 GMT
Subject: Re: [PATCH] filter-branch -d: Export GIT_DIR earlier
Message-ID: <20090216145137.GA4431@lars.home.noschinski.de>
In-Reply-To: <alpine.DEB.1.00.0902161441190.6289@intel-tinevez-2-302>

Hello,

* Johannes Schindelin <Johannes.Schindelin@gmx.de> [09-02-16 15:42]:
>> This fix is not yet ready for commit, as it lacks a test case.
>> 
>> Writing a test case for this bug, I wonder about the preferred way to use a
>> directory outside any git repository in a test: Using some directory below
>> git/t/ will not work, as (in most cases) git is a git repository.
>
>How about using a filter-branch call with a filter that echoes GIT_DIR 
>into a file, then fails, and then checking the exact contents of GIT_DIR?

This would not catch this bug: for-each-ref is the only git command
called after changing to the temporary directory and before exporting
GIT_DIR.

It would help only if GIT_DIR would never be exported.

 - Lars.