Re: [PATCH] filter-branch -d: Export GIT_DIR earlier

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 16, 2009, 15:39 UTC
Message-ID: <alpine.DEB.1.00.0902161636040.6289@intel-tinevez-2-302>
In-Reply-To: <20090216145137.GA4431@lars.home.noschinski.de>

Hi,

On Mon, 16 Feb 2009, Lars Noschinski wrote:

Show 14 quoted lines

> * Johannes Schindelin <Johannes.Schindelin@gmx.de> [09-02-16 15:42]:
> > > This fix is not yet ready for commit, as it lacks a test case.
> > > 
> > > Writing a test case for this bug, I wonder about the preferred way to use
> > > a
> > > directory outside any git repository in a test: Using some directory below
> > > git/t/ will not work, as (in most cases) git is a git repository.
> >
> >How about using a filter-branch call with a filter that echoes GIT_DIR into a
> >file, then fails, and then checking the exact contents of GIT_DIR?
> 
> This would not catch this bug: for-each-ref is the only git command
> called after changing to the temporary directory and before exporting
> GIT_DIR.

Right.

Next try: is it not true that we can check that "$tempdir/backup-refs" is correct, i.e. identical to what 'for-each-ref' outputs for the desired directory?

So we could make a subdirectory, set up a dummy branch with one commit, call filter-branch with a tmpdir that is in _another_ subdirectory, with a filter that just returns false, so that the tmpdir is not deleted, and verify the contents of $tmpdir/backup-refs, no?

Ciao, Dscho