git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] parse-opt: migrate builtin-ls-files.

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Feb 15, 2009, 22:07 UTC
Message-ID
<20090215220706.GB4371@genesis.frugalware.org>
In-Reply-To
<alpine.DEB.1.00.0902152108370.10279@pacific.mpi-cbg.de>
On Sun, Feb 15, 2009 at 09:13:42PM +0100, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 12 quoted lines
> > > > +   dir->show_ignored = !unset;
> > > > +
> > > > +   return 0;
> > > > +}
> > >
> > > Maybe this wants to be converted into an OPTION_BIT compatible data 
> > > type?
> > 
> > I think that's not possible, as show_ignored is a bitfield.
> 
> Well, in my juvenile folly I dreamt of turning this into a proper 
> bitfield...
Uhm, I think I haven't got what you mean. ;-)

Personally I would just remove all problematic bitfields in struct dir_struct as I think it does not worth using them, but getting rid of them just because of parseopt sounds insane as well - so I sended up writing callback functions, as you saw in the patch.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 16 of 19 in “parse-opt: migrate builtin-ls-files.”
  1. parse-opt: migrate builtin-ls-files.Miklos Vajna, Jan 6, 2009
  2. Pierre HabouzitJan 6, 2009
  3. parse-opt: migrate builtin-ls-files.Miklos Vajna, Jan 7, 2009
  4. Pierre HabouzitJan 7, 2009
  5. parse-opt: migrate builtin-ls-files.Miklos Vajna, Jan 8, 2009
  6. Johannes SchindelinJan 8, 2009
  7. Miklos VajnaJan 8, 2009
  8. Miklos VajnaJan 15, 2009
  9. Junio C HamanoJan 15, 2009
  10. Miklos VajnaJan 15, 2009
  11. Miklos VajnaFeb 14, 2009
  12. Junio C HamanoFeb 14, 2009
  13. Johannes SchindelinFeb 14, 2009
  14. parse-opt: migrate builtin-ls-files.Miklos Vajna, Feb 15, 2009
  15. Johannes SchindelinFeb 15, 2009
  16. Miklos VajnaFeb 15, 2009
  17. Turn the flags in struct dir_struct into a single variableJohannes Schindelin, Feb 16, 2009
  18. Miklos VajnaFeb 16, 2009
  19. parse-opt: migrate builtin-ls-files.Miklos Vajna, Feb 17, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.