From: Miklos Vajna <vmiklos@frugalware.org>
Date: Sun, 15 Feb 2009 22:07:06 GMT
Subject: Re: [PATCH] parse-opt: migrate builtin-ls-files.
Message-ID: <20090215220706.GB4371@genesis.frugalware.org>
In-Reply-To: <alpine.DEB.1.00.0902152108370.10279@pacific.mpi-cbg.de>

On Sun, Feb 15, 2009 at 09:13:42PM +0100, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > > > +   dir->show_ignored = !unset;
> > > > +
> > > > +   return 0;
> > > > +}
> > >
> > > Maybe this wants to be converted into an OPTION_BIT compatible data 
> > > type?
> > 
> > I think that's not possible, as show_ignored is a bitfield.
> 
> Well, in my juvenile folly I dreamt of turning this into a proper 
> bitfield...

Uhm, I think I haven't got what you mean. ;-)

Personally I would just remove all problematic bitfields in struct
dir_struct as I think it does not worth using them, but getting rid of
them just because of parseopt sounds insane as well - so I sended up
writing callback functions, as you saw in the patch.