Re: libgit2 - a true git library

From: Shawn O. Pearce <spearce@spearce.org>
Date: Oct 31, 2008, 23:25 UTC
Message-ID: <20081031232539.GB14786@spearce.org>
In-Reply-To: <490B9262.5070905@gmail.com>

Bruno Santos <nayart3@gmail.com> wrote:

Show 14 quoted lines

> Shawn O. Pearce wrote:
> > During the GitTogether we were kicking around the idea of a ground-up
> > implementation of a Git library.
> 
> We should take the opportunity a make it more portable. Instead of using
> the posix api directly we should warp it in "git_" APIs. And be carefull
> with certain APIs like fork or fork+exec [...]
> 
> Here's an example, for the 'read' API, on how we can simply do this
> without worries for the posix crowd:
> 
> ssize_t git_read(git_fildes_t fildes, void* buf, size_t bufsize);
> 
> Were git_fildes_t would be an int for posix and an HANDLE for win32.

...

Yes, already on my mind. _IF_ this carries further I'll be involved with its development, and I'll make certain its reasonably portable like you are asking.

There are only a handful of things we really need to from the OS and I think we can wrap most of them up into little inline stubs on POSIX (so POSIX folks have no impact) and on Win32 we can have small stubs (or again inline) so its pretty native on Win32.

Yes, I have considered say NPR or APR; I'm not going there. Both are nice packages but there's also downsides to bringing them into libgit2. IMHO its just easier to wrap the handful of things we really need.

-- 
Shawn.