git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: grep portability fixes

From
Jeff King <peff@peff.net>
Date
Sep 30, 2008, 12:45 UTC
Message-ID
<20080930124522.GA22182@coredump.intra.peff.net>
In-Reply-To
<48E1FF6D.1050907@viscovery.net>
On Tue, Sep 30, 2008 at 12:29:01PM +0200, Johannes Sixt wrote:
Show 10 quoted lines
> Andreas Ericsson schrieb:
> > Jeff King wrote:
> >> -    if ! grep -qe "Invalid gitfile format" .err
> >> +    if ! grep "Invalid gitfile format" .err
> > 
> > Doesn't output need to be redirected when you drop '-q'?
> 
> In standard mode, the test output is directed to /dev/null anyway, and in
> verbose mode the extra output doesn't hurt at all, and is usually useful
> because you know that a pattern matched.

Exactly. This is the more of the same as aadbe44f (grep portability fix: don't use "e" or "-q") but I was too lazy to rewrite the justification completely (but I did reference it).

-Peff
Previous: Johannes SixtNext: Johannes Sixt
Message 4 of 7 in “tests: grep portability fixes”
  1. tests: grep portability fixesJeff King, Sep 30, 2008
  2. Andreas EricssonSep 30, 2008
  3. Johannes SixtSep 30, 2008
  4. Jeff KingSep 30, 2008
  5. Johannes SixtSep 30, 2008
  6. Mike RalphsonSep 30, 2008
  7. Jeff KingSep 30, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.