Re: [PATCH] tests: grep portability fixes
- From
Jeff King <peff@peff.net>
- Date
- Sep 30, 2008, 12:44 UTC
- Message-ID
- <20080930124413.GA22078@coredump.intra.peff.net>
- In-Reply-To
- <e2b179460809300410q47592f63y7f7ec626007ad838@mail.gmail.com>
On Tue, Sep 30, 2008 at 12:10:19PM +0100, Mike Ralphson wrote:
Show 10 quoted lines
> > There is one exception for "-e" here, which is in t7701 used > > to produce an "or" of patterns. This can be rewritten as an > > egrep pattern. > > > > This patch also removes use of "grep -F" in favor of the > > more widely available "fgrep". > > Works here too (AIX 5.3) > > Tested-by: Mike Ralphson <mike@abacus.co.uk>
Thanks Mike and Johannes. The dropping of "-e" and "-q" we had done before, but this was our first use of egrep and fgrep. From my (admittedly limited) knowledge, I think they are fine, but it is nice to have some confirmation.
-Peff